feat(api-server): Add HTTPS support and custom certificate configuration #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add useHttps, certPath, and keyPath fields to APIServerConfig interface and default config. - These fields allow toggling HTTPS and specifying certificate and key file paths for the API server.
- Add a submenu for HTTPS settings in the API server plugin menu. - Allow users to enable HTTPS and select certificate and key files via file dialogs. - Fetch latest config before updating cert/key paths to avoid overwriting values.
- Add labels and dialog titles for HTTPS submenu, certificate, and key selection in the API server plugin.
- Update BackendType to include new HTTPS config fields. - Change run method to accept full APIServerConfig object.
- Update backend to start an HTTPS server when enabled in config, using provided cert and key paths. - Ensure server restarts on any relevant config change (hostname, port, useHttps, certPath, keyPath).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds HTTPS support to the API server plugin, allowing users to enable HTTPS and provide custom certificate and private key files for secure API access.
Key changes:
useHttps,certPath, andkeyPathfields to the API server config.Why:
This enables secure remote control and API access over HTTPS, addressing feature request #3647.
Testing:
closes #3647