diff --git a/.github/workflows/model_uploader.yml b/.github/workflows/model_uploader.yml index 2db0137e..be55b762 100644 --- a/.github/workflows/model_uploader.yml +++ b/.github/workflows/model_uploader.yml @@ -264,7 +264,7 @@ jobs: with: secret: ${{ github.TOKEN }} approvers: ${{ steps.get_approvers.outputs.approvers }} - minimum-approvals: 1 + minimum-approvals: 2 issue-title: "Upload Model to OpenSearch Model Hub (${{ github.event.inputs.model_id }})" issue-body: ${{ steps.create_issue_body.outputs.issue_body }} exclude-workflow-initiator-as-approver: false diff --git a/CHANGELOG.md b/CHANGELOG.md index 74b48f63..85444612 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Make the model tracing-uploading-releasing workflow fail early for ≥2GB model by @thanawan-atc ([#258](https://github.com/opensearch-project/opensearch-py-ml/pull/258)) - Rename model/model-listing workflows by @thanawan-atc ([#260](https://github.com/opensearch-project/opensearch-py-ml/pull/260)) - Update pretrained_models_all_versions.json (2023-08-30 14:07:38) by @dhrubo-os ([#264](https://github.com/opensearch-project/opensearch-py-ml/pull/264)) +- Have model upload workflow require approval from two code maintainers by @thanawan-atc ([#273](https://github.com/opensearch-project/opensearch-py-ml/pull/273)) ### Fixed - Enable make_model_config_json to add model description to model config file by @thanawan-atc in ([#203](https://github.com/opensearch-project/opensearch-py-ml/pull/203))