New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format option is required when the Swift provider calls ncw/swift's ObjectNames() #53

Open

yheonhochoi opened this issue May 18, 2023 · 0 comments

yheonhochoi commented May 18, 2023

Hello.

When using Swift as Object Storage in Thanos, call ncw/swift's ObjectNames() to get the entire list of Objects.

https://github.com/thanos-io/thanos/blob/main/pkg/block/fetcher.go#L366
https://github.com/thanos-io/objstore/blob/main/providers/swift/swift.go#L221
https://github.com/ncw/swift/blob/master/swift.go#L1057-L1070

At this time, ncw/swift assumes that the response is text/plain and parses it (this is the default format of openstack swift).

Depending on the settings of openstack swift, this response can be in json format.

I requested that ncw/swift also be able to parse json if it is, but the thanos side also needs to decide on this use.

When Thanos Fetcher calls objstore, it is executed with format (plain) parameters or headers
Or Objstore (swift provider) excute with format (plain) parameter or header when calling ncw/swift

Or is there a better way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment