Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QFE should optionally expose httpgrpc on through gRPC #7905

Open
GiedriusS opened this issue Nov 14, 2024 · 2 comments
Open

QFE should optionally expose httpgrpc on through gRPC #7905

GiedriusS opened this issue Nov 14, 2024 · 2 comments

Comments

@GiedriusS
Copy link
Member

Is your proposal related to a problem?

I want to use Cortex Ruler with Thanos (and bring these two projects closer together) but Cortex Ruler uses https://github.com/weaveworks/common/tree/master/httpgrpc to send requests. Since the Cortex project prefers using gRPC, let's implement this interface in Thanos QFE.

Describe the solution you'd like

Adding an optional gRPC server to QFE that exposes this interface.

Describe alternatives you've considered

N/A

Additional context

N/A

@cswpy
Copy link
Contributor

cswpy commented Dec 31, 2024

I can take this issue

@cswpy
Copy link
Contributor

cswpy commented Dec 31, 2024

As I am new to the repo, just want to double-check the steps to host a gRPC server in QFE:

  1. Add a grpcConfig to queryFrontendConfig and a flag to query-frontend parser.
  2. Add weaveworks/common as a dependency
  3. Use its httpgrpc to spin up a gRPC server
  4. Translates the HTTP to gRPC, send to the HTTP server, and translates the response back

While I have not figured out how to implement step 4 in detail, just want to double-check this looks like a solid plan before digging in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants