Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: hitting enter in add item form does not work #102

Open
jtkabenni opened this issue Mar 31, 2024 · 2 comments
Open

Bug: hitting enter in add item form does not work #102

jtkabenni opened this issue Mar 31, 2024 · 2 comments

Comments

@jtkabenni
Copy link
Collaborator

No description provided.

@flbarfield
Copy link
Collaborator

flbarfield commented Mar 31, 2024

I actually wanted to talk about this!

While hitting enter while in an input field is the expected user experience, it may be more troublesome if the user meant to add a specific reminder duration. Because in that case, they would have to tab down to the list, delete the item, tab back up, and then re-add the item, all the while making extra DB calls...And all of those extra steps could be avoided if we only allow them to add the item when hitting enter when the "add item" button is in focus

Maybe we could display an error message on enter key if that input is focused, and the user hasn't selected a duration? Should it react the same when clicking add item without a duration selected?

@jtkabenni
Copy link
Collaborator Author

Thanks for clarifying @flbarfield, that makes a lot of sense.
I'm not too sure on the accessibility of i all but I do remember something about wanting to allow the use to submit forms by hitting enter? It would work since we already have a default selected for 7 days.
I guess this would be an issue if they did want to select another duration. We can keep it like this but revisit it when we get to our accessibility ticket later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants