Inline Tabs for Actor sheets - Pop-Out! workaround #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the styling is not great... at all... I did make the decision that I left out the labels on the tabs as there are too many of them for the space on the sheet. Though if people think adding them back for accessibility is better, we could look at stacking icon over text? |
zithith
added
ui
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Added a setting toggle (as per the item sheet one, but inverted) to make the tabs for actor sheets fall in-line, more like the default foundry behaviour. Required a small re-factor of the navigation parts for the actor sheets so that they appear in a relevant place in the sheet structure.
Related Issue
Closes #194
How Has This Been Tested?
Local machine. Opened sheets with and without the setting toggled to see the change (doesn't re-render already opened sheets).
Screenshots (if applicable)
Checklist: