Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"End-of-Rib Marker" printed even when there are withdrawn routes #746

Open
fenner opened this issue Apr 11, 2019 · 1 comment
Open

"End-of-Rib Marker" printed even when there are withdrawn routes #746

fenner opened this issue Apr 11, 2019 · 1 comment
Labels
bug
Milestone
release_after_next

Comments

@fenner
Copy link
Contributor

fenner commented Apr 11, 2019

tcpdump/print-bgp.c

Line 2770 in dcf8303

if (withdrawn_routes_len == 0 && len == 0 && length == 0) {

withdrawn_routes_len is decremented while parsing the withdrawn routes, so if the withdrawn section is present but well-formed, withdrawn_routes_len will be zero.
@mcr mcr added the bug label Apr 16, 2019
@mcr mcr added this to the release_after_next milestone Apr 16, 2019
LiorBenYamin added a commit to LiorBenYamin/tcpdump that referenced this issue Apr 5, 2020
@LiorBenYamin
fixed bug the-tcpdump-group#746
68896c9
@fxlb
Copy link
Member

fxlb commented May 14, 2020

Thanks.
Do you have a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
release_after_next
Development

No branches or pull requests
3 participants
@mcr @fenner @fxlb