Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issue #24

Open
RudraNirvan opened this issue Mar 19, 2019 · 11 comments
Open

UI issue #24

RudraNirvan opened this issue Mar 19, 2019 · 11 comments

Comments

@RudraNirvan
Copy link

image

Is there some styling that needs to be added?

@thealeksandr
Copy link
Owner

@RudraNirvan Shouldn't be like that. Could you give me more info about what you did?

@MaximKulikov
Copy link

MaximKulikov commented May 16, 2019

@RudraNirvan I got simular result when set android:background = white for theme in manifest for that activity.

@MaximKulikov
Copy link

@thealeksandr I found fragment_lock_screen_pf.xml line:19 -> android:paddingBottom="60dp". What was the idea to separate those content from bottom button with 60 dp?

@thealeksandr
Copy link
Owner

@MaximKulikov can you give me more details how you get the above result? What's the problem with the padding?

@MaximKulikov
Copy link

@thealeksandr I figure, i can put fragment_lock_screen_pf.xml in project res and it override layout from library, so i can do with button whatether i want, so it not issue anymore.

@meidikawardana
Copy link

any progress on this issue? I got this issue, & I suspect this is something related with app / activity theme. I am using Theme.MaterialComponents from this gradle:

implementation 'com.google.android.material:material:1.1.0-beta01'

maybe you can reproduce this issue with that theme, @thealeksandr

@thealeksandr
Copy link
Owner

@meidikawardana I wasn't able to reproduce. Can you provide me more details? what android version? Can you reproduce on emulator? Have you tried to update library?

@meidikawardana
Copy link

@thealeksandr I created a sample project for reproduce this issue. looks like you need to create a custom theme for activity too. and add background color white to that activity theme. but importantly, the app theme must be Theme.MaterialComponents . Here is my sample: https://drive.google.com/open?id=1Ir5_HPA9rVOBHYTVOXx_kntGQjK6J0B7

@thealeksandr
Copy link
Owner

@meidikawardana looking into it

@thealeksandr
Copy link
Owner

@meidikawardana @RudraNirvan @MaximKulikov from the demo above I found that this can happen when there's this line for theme style<item name="android:background">#fff</item>. This line shouldn't be used in theme style. This will basically override backgrounds for all elements inside activity where background not set

@thealeksandr thealeksandr added this to the 1.0.0-beta7 milestone Nov 4, 2019
@meidikawardana
Copy link

meidikawardana commented Nov 4, 2019

ok, thank you for your response @thealeksandr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants