Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 Support #5846

Open
larson-carter opened this issue Mar 13, 2024 · 14 comments
Open

Laravel 11 Support #5846

larson-carter opened this issue Mar 13, 2024 · 14 comments

Comments

@larson-carter
Copy link

Laravel version

11

PHP version

8.2

Voyager version

1.7

Database

PostgresQL

Description

There is not laravel 10 or really laravel 11 support. It would be ideal if we could modernize and develop the application to be inclusive of this new framework.

Steps to reproduce

Attempt to install

Expected behavior

Install and work as it does on older versions

Screenshots

No response

Additional context

No response

@schruptor
Copy link

schruptor commented Mar 14, 2024

@larson-carter Laravel 10 support is available. It's in the non-default branch of version 1.7.(https://github.com/thedevdojo/voyager/tree/1.7) (https://github.com/thedevdojo/voyager/releases/tag/v1.7)

But Laravel 11 support would be really great.

@alexandrbarabolia
Copy link

We need laravel 11 👍

@larson-carter
Copy link
Author

@schruptor Yes, laravel 10 works great on that 1.7 branch (I think that it is stable enough for it to be on the default branch, just needs to be merged). However, there is no Laravel 11 support.

Maybe if I get time in a few weekends I will come back and make 11 support unless someone beats me to it.

@cotiga
Copy link
Contributor

cotiga commented Mar 31, 2024

I think it will take a while (if it will ever be done...), because the loss of Doctrine DBAL seems like a gigantic undertaking for Voyager to overcome 😔

@larson-carter
Copy link
Author

@cotiga I completely agree. 11 was a big jump over 10, heck really 9.

I do think that there are a different items that make this upgrade quite a challenge.

I just do not know of any alternatives that do the same functionality and are as modern/flexible.

@kozimjon-malikov
Copy link

We have to create adaptable version for all

@duran004
Copy link

duran004 commented Jun 7, 2024

I don't think there is a big jump from laravel 10 to 11, just some folders have been deleted, a simpler skeleton and now the project is started via bootstrap, that's all.

@larson-carter
Copy link
Author

@duran004 Laravel 10 to 11 is quite a massive jump under the hood. It is not just folders being deleted or hidden.

Internal kernel functionality has been significantly modified.

@fletch3555 fletch3555 mentioned this issue Jul 3, 2024
@soinalastudio
Copy link

Has anyone reviewed/tested this commit for a support of Laravel 11 a4e3eef

@jonathanribas
Copy link

jonathanribas commented Aug 20, 2024

Hi,
Laravel 10 bug fixes are over since 7th August 2024, PHP 8.2 Security fixes until February 2025.
Someone started something here: #5801

@bobbyiliev
Copy link
Contributor

bobbyiliev commented Sep 23, 2024

Has anyone reviewed/tested this commit for a support of Laravel 11 a4e3eef

That 1.8 branch is still a work in progress. It is still not fully compatible with Laravel 11 though as the TCG\Voyager\Database\Types; still uses the deprecated Doctrine DBAL.

A lot of the BREAD functionality really depends on that Doctrine DBAL package which is no longer compatible with Laravel 11.

image

@bobbyiliev
Copy link
Contributor

bobbyiliev commented Sep 26, 2024

Quick update on the above, the 1.8 branch now works with Laravel 11.

This release includes some bug fixes and package updates to make it compatible with Laravel 11 with one exception:

Warning

As of Laravel 11 the Doctrine DBAL package has been removed from Laravel. This currently breaks the Voyager Database Manager. We are working on a fix for this, but in the meantime, you can just use the Laravel Database migrations to manage your database instead. The Voyager database manager might get deprecated in the next release.

image

@pckz
Copy link

pckz commented Dec 4, 2024

Hey guys, thanks for your amazing job with this lib. Any news with the Laravel 11 support?
Bread is not working for users entity

@bobbyiliev
Copy link
Contributor

Hey guys, thanks for your amazing job with this lib. Any news with the Laravel 11 support? Bread is not working for users entity

Hey!

Laravel 11 should mostly work with: https://github.com/thedevdojo/voyager/releases/tag/v1.8.0

However as per the warning in the release:

As of Laravel 11 the Doctrine DBAL package has been removed from Laravel. This currently breaks the Voyager Database Manager. We are working on a fix for this, but in the meantime, you can just use the Laravel Database migrations to manage your database instead. The Voyager database manager might get deprecated in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants