From b1bafc9b8cf1ba87bcf73469f16bafdf3a53ceda Mon Sep 17 00:00:00 2001 From: javed231450 Date: Fri, 27 Sep 2024 18:30:40 +0530 Subject: [PATCH 1/3] Create pylint.yml --- .github/workflows/pylint.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/pylint.yml diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml new file mode 100644 index 00000000000..c73e032c0f3 --- /dev/null +++ b/.github/workflows/pylint.yml @@ -0,0 +1,23 @@ +name: Pylint + +on: [push] + +jobs: + build: + runs-on: ubuntu-latest + strategy: + matrix: + python-version: ["3.8", "3.9", "3.10"] + steps: + - uses: actions/checkout@v4 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v3 + with: + python-version: ${{ matrix.python-version }} + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install pylint + - name: Analysing the code with pylint + run: | + pylint $(git ls-files '*.py') From b3fc3dd6f06ceefaedf6f29deebbcfdbed6aba5c Mon Sep 17 00:00:00 2001 From: javed231450 Date: Sat, 28 Sep 2024 17:53:43 +0530 Subject: [PATCH 2/3] --- client3.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/client3.py b/client3.py index 3fc09b75f16..484ab19cd87 100644 --- a/client3.py +++ b/client3.py @@ -35,14 +35,17 @@ def getDataPoint(quote): stock = quote['stock'] bid_price = float(quote['top_bid']['price']) ask_price = float(quote['top_ask']['price']) - price = bid_price + price = (bid_price + ask_price)/2 return stock, bid_price, ask_price, price def getRatio(price_a, price_b): """ Get ratio of price_a and price_b """ """ ------------- Update this function ------------- """ - return 1 + if (price_b == 0): + #when price_b will 0 then zero avoid zeroDivisionError + return + return price_a/price_b # Main @@ -52,8 +55,10 @@ def getRatio(price_a, price_b): quotes = json.loads(urllib.request.urlopen(QUERY.format(random.random())).read()) """ ----------- Update to get the ratio --------------- """ + price = {} for quote in quotes: stock, bid_price, ask_price, price = getDataPoint(quote) + prices[stock]=price print("Quoted %s at (bid:%s, ask:%s, price:%s)" % (stock, bid_price, ask_price, price)) - print("Ratio %s" % getRatio(price, price)) + print("Ratio %s" % getRatio(prices["ABC"], prices["DEF"])) From 96bde16b6637f5d4e27405a65ff17fc69a9e9d56 Mon Sep 17 00:00:00 2001 From: javed231450 Date: Sat, 28 Sep 2024 19:57:56 +0530 Subject: [PATCH 3/3] Patch file --- client_test.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/client_test.py b/client_test.py index af2bf26b3cc..54a36bd5629 100644 --- a/client_test.py +++ b/client_test.py @@ -8,6 +8,8 @@ def test_getDataPoint_calculatePrice(self): {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'} ] """ ------------ Add the assertion below ------------ """ + for quote in quotes: + self.assertEqual (getDataPoint(quote), (quote['stock'],quote['top_bid']['price'], quote['ask_bid']['price'],(quote['top_bid']['price'] + quote['top_ask']['price'])/2)) def test_getDataPoint_calculatePriceBidGreaterThanAsk(self): quotes = [ @@ -15,10 +17,13 @@ def test_getDataPoint_calculatePriceBidGreaterThanAsk(self): {'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'} ] """ ------------ Add the assertion below ------------ """ + for quote in quotes: + sel.assertEqual (getDataPoint(quote), (quote['stock'],quote['top_bid']['price'], quote['top_ask']['price'], (quote['top_bid']['price'] + quote['top_ask']['price'])/2)) - """ ------------ Add more unit tests ------------ """ + """ ------------ Add more unit tests ------------ """ + self.assertEqual(1,1) if __name__ == '__main__':