Fixes #37573 - Load managed columns on All Hosts correctly #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
force-pushed
the
managed-columns
branch
from
1ef9480 to
be04d47
Compare
|
Steps to test Before PR
After PR
|
parthaa
force-pushed
the
managed-columns
branch
2 times, most recently
from
28df00e to
7b59821
Compare
|
The redmine was in the Katello project and not Foreman. I fixed the redmine but this will need another rebase to get PRProcessor happy. |
parthaa
force-pushed
the
managed-columns
branch
from
7b59821 to
7957c05
Compare
rebased |
jeremylenz
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
- Manage Columns shows up on hard reload
- Manage Columns shows up immediately from Register Host page without reloading
- Columns from plugins continue to be 100% present
Works great, thanks @parthaa!
ACK 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loads the managed columns correctly if navigating from another page to All Hosts.