Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38209 - vmware Create controller select freezes the page #10440

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Feb 12, 2025

after selecting, a change happens, but the select2 still thinks the select dropdown is open and prevents scroll, instead if we use the select2 events it doesnt happen. https://select2.org/programmatic-control/events
to reproduce create host -> Deploy On = vmware -> virtual machine tab -> select a cluster -> select "create controller"
after that the page cant be scrolled

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to resolve the issue and I haven't noticed anything else being affected by this.

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga and @adamruzicka !

@ofedoren ofedoren merged commit 0fbdc0f into theforeman:develop Feb 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants