Fixes #38220 - page scroll freeze in host edit unselect arch #10446
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Legacy JS
MariaAga
force-pushed
the
select-38220
branch
2 times, most recently
from
00c4d5e to
388e8b2
Compare
|
need to fix subnet not being selected after domain selection |
MariaAga
force-pushed
the
select-38220
branch
2 times, most recently
from
3e8b77d to
688f094
Compare
|
We should probably cp it in 3.13 |
I think you meant #10447? |
|
I meant 10447, oops |
MariaAga
force-pushed
the
select-38220
branch
from
688f094 to
e76117b
Compare
ofedoren
added
the
Needs cherrypick
ofedoren
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Thanks, @MariaAga ! Code-wise can't tell much :/ The changes look fine to me though. More importantly that it actually fixes the issue with scrolling for plain Foreman. I also couldn't encounter any more regressions caused by this PR.
We will need to CP it into 3.14-stable though.
This was referenced Feb 19, 2025
|
cp: #10452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to create host page, OS tab, select Architecture, unselect Architecture, try to scroll down, cant scroll down.
same solution as in #10440
also
.host-architecture-selectdoesnt exist which might be why there was the extra:onchageinapp/views/hosts/_operating_system.html.erb, changed to select by id