Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP 3.13] Fixes #38223 - host_edit when no inherit button creates error #10454

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

MariaAga
Copy link
Member

(cherry picked from commit c97a40e)
#10447

When editing a host, in foreman core without plugins, there is no inherit button on any of the fields, the causes this error:
Uncaught TypeError: document.querySelector(...) is null host_edit-a353532802cf651d1f8eaecab20ef1d6620e03c07c776b03559e9b18bebc15cf.js:1
for some reasons it makes it so the submit button redirects to the old details page, but still with the edit url
This causes the old details page to load on a loop

This is a bug when users have the old hosts details page as default,
We might want to cp it in 3.13, to work around a user can go to the details page and/or delete the the /edit from the url, or just set up to use the new page

@pr-processor pr-processor bot added Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Feb 19, 2025
@github-actions github-actions bot added the Legacy JS PRs making changes in the legacy Javascript stack label Feb 19, 2025
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga !

The test failures are worrying, but don't seem to be related as UI tests are green.

We might need to do some other CPs into this branch if we want it green...

@ofedoren ofedoren merged commit 1a4bf20 into theforeman:3.13-stable Feb 20, 2025
32 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy JS PRs making changes in the legacy Javascript stack Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants