Add ability to have multiple source files in createSent for starfall_… (#1992)

* Add ability to have multiple source files in createSent for starfall_processor

* fixes

* fix

Author: thegrb93

lua/starfall/instance.lua

@@ -531,7 +531,7 @@ function SF.Instance:runExternal(func, ...)
 	self:pushCpuCheck()
 	local ok, err = xpcall(func, debug.traceback, ...)
 	self:popCpuCheck()
-	if ok then return err else ErrorNoHalt(err) end
+	return ok, err
 end
 
 local function xpcall_callback(err)

lua/starfall/libs_sv/prop.lua

@@ -605,14 +605,7 @@ function props_library.createSent(pos, ang, class, frozen, data)
 		enttbl.Pos = pos
 		enttbl.Angle = ang
 
-		-- Temporarily disable SF runningOps, because SENT like E2 rely on string metatable methods!
-		-- E2 calls string:find with colon sugar syntax, this means E2 code ended up calling into string __index metamethod (see sflib.lua where SF does metatable patching).
-		-- In case of E2, it usually results in obscure errors being thrown (such as "error in error handling", random things being nil, etc).
-		local runningOpsBackup = SF.runningOps
-		SF.runningOps = nil
-
-		-- Better be safe, pcall this to ensure we continue running our code, in case these external functions cause an error...
-		local isOk, errorMsg = pcall(function()
+		local isOk, errorMsg = instance:runExternal(function()
 			if sent2._preFactory then
 				sent2._preFactory(ply, enttbl)
 			end
@@ -638,7 +631,6 @@ function props_library.createSent(pos, ang, class, frozen, data)
 			end
 		end)
 
-		SF.runningOps = runningOpsBackup -- Restore back runningOps to SF control, and everything is fine :)
 		if not isOk then
 			if IsValid(entity) then
 				entity:Remove()

lua/starfall/libs_sv/prop_sent.lua

@@ -1011,13 +1011,23 @@ registerSent("gmod_wire_expression2", {
 		["inc_files"] = {TYPE_TABLE, {}},
 	}
 })
+end
+end)
 
 registerSent("starfall_processor", {
 	_preFactory = function(ply, self)
 	end,
 	_postFactory = function( ply, self, enttbl )
+		local Files = {
+			["main"] = enttbl.Code
+		}
+		for path, code in pairs(enttbl.Files) do
+			checkluatype(path, TYPE_STRING, 3, "Parameter: Files[" .. path .. "]")
+			checkluatype(code, TYPE_STRING, 3, "Parameter: Files[" .. path .. "]")
+			Files[path] = code
+		end
 		local Data = {
-			["files"] = {["main"] = enttbl.Code},
+			["files"] = Files,
 			["mainfile"] = "main",
 			["owner"] = ply
 		}
@@ -1026,12 +1036,10 @@ registerSent("starfall_processor", {
 	{
 		["Model"] = {TYPE_STRING, "models/spacecode/sfchip_medium.mdl"},
 		["Code"] = {TYPE_STRING},
+		["Files"] = {TYPE_TABLE, {}}
 	}
 })
 
-end
-end)
-
 function SF.PrintCustomSENTDocs()
 	local tostr = {
 		string = function(x) return "\"" .. x .. "\"" end,
@@ -1330,6 +1338,7 @@ return function() end
 -- > starfall_processor
 -- string Model = "models/spacecode/sfchip_medium.mdl"
 -- string Code
+-- table Files = {main = Code}
 -- 
 -- > gmod_wire_extbus
 -- string Model = "models/jaanus/wiretool/wiretool_gate.mdl"

lua/starfall/libs_sv/wire.lua

@@ -648,7 +648,8 @@ end
 local function readCell(ent, k)
 	checkpermission(instance, nil, "wire.wirelink.read")
 	local ReadCell = Ent_GetTable(ent).ReadCell or SF.Throw("Entity does not have ReadCell capability", 3)
-	return tonumber(instance:runExternal(ReadCell, ent, k))
+	local ok, n = instance:runExternal(ReadCell, ent, k)
+	return ok and tonumber(n) or 0
 end
 
 --- Sets the value of an entity's input, triggering it as well