Add MDL, VVD, VTX and PHY to file.write whitelist

[Spalishe]

Adding the extensions .mdl, .vvd, .vtx, and .phy to the file library whitelist sounds like a good idea, especially considering that .vtf and .vmt files are included in this list.

[thegrb93]

No those formats are very good at crashing clients. I don't think you can even load models from the data directory

[Spalishe]

Models can be loaded even from sf_filedata by adding two dots to path

models/../data/sf_filedata/testModel/chise.mdl

[ax255]

.obj could be good to be added to the list

[wrefgtzweve]

Gmod has a whitelist by itself keep that in mind, see https://wiki.facepunch.com/gmod/file.Write

[Spalishe]

Seems page isn't updated yet Facepunch/garrysmod-requests#2188

[wrefgtzweve]

👍 you're right, it's updated now

[thegrb93]

If someone wants to write a checker to sanitize the model data, then I think we can have this. pac3 and outfitter would also benefit from a model sanitizer. Right now they just write a data file if the model crashes the player.

[wrefgtzweve]

Outfitter stores the loading model, if it crashes during the loading it'll automatically blacklist the model
Kinda neat but not perfect obviously

[thegrb93]

I marked help wanted because I'm not really interested in dissecting the model format again and making a validator anytime soon, although it is a really simple format.

[wrefgtzweve]

Do note, even if the model is valid it can cause crashes sadly. Weird ragdolls especially can crash clients on death.

[Pr0st1m]

DA :3