feat: add fecEntregaBienes property and XML template support#272
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request adds support for handling the delivery date of goods to the carrier in the shipment despatch process. The main changes include introducing a new property to the
Shipmentmodel, providing getter and setter methods for it, and updating the XML template to include this date if present.Shipment model enhancements:
fecEntregaBienesto theShipmentclass to store the delivery date of goods to the carrier.fecEntregaBienesproperty in theShipmentclass.XML template update:
despatch2022.xml.twigto include a<cac:LoadingTransportEvent>section with thefecEntregaBienesdate if it is available.cc @lecano