Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Only consider fees of MAX_TXS_PER_COMMIT txns when prioritizing what to pack #628

Open
jacque006 opened this issue Jul 16, 2021 · 1 comment
Labels
client This PR is about implementing the client

Comments

@jacque006
Copy link
Collaborator

See #621 (comment)

Problem

Currently, when determining the next token to pack, the value of all pending tokens in a queue is considered even though only 32 (MAX_TXS_PER_COMMIT) of them will e packed into a commitment https://github.com/thehubbleproject/hubble-contracts/blob/master/ts/client/txPool.ts#L156-L158

Solution

  • Only evaluate the 32 (MAX_TXS_PER_COMMIT) txns for a token with the highest fees when considering what to pack.
  • Consider updating feeReceivers to have a container class as well Multi Token Pool #621 (comment)
@jacque006 jacque006 added the client This PR is about implementing the client label Jul 16, 2021
@jacque006 jacque006 added this to the Public Testnet 2 milestone Jul 16, 2021
@jacque006 jacque006 mentioned this issue Jul 16, 2021
3 tasks
@jacque006
Copy link
Collaborator Author

For "...feeReceivers to have a container class", consider using https://github.com/thehubbleproject/hubble-contracts/blob/master/ts/client/tokenbase.ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client This PR is about implementing the client
Projects
None yet
Development

No branches or pull requests

1 participant