Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite must actually build some fonts #45

Open
alerque opened this issue Jun 29, 2020 · 0 comments
Open

Test suite must actually build some fonts #45

alerque opened this issue Jun 29, 2020 · 0 comments

Comments

@alerque
Copy link
Member

alerque commented Jun 29, 2020

I don't know how to lay this out (external demo repositories? script to generate them internally? tarballs?) but one way or another the test suite for fontship itself must include generating fronts from various different canonical sources. Already I've broken master multiple times with unexpected side effects that don't impact the thing I was testing but do affect other font projects. Testing that fontship itself builds and runs isn't enough, it needs to generate expected results from actual font sources.

@alerque alerque changed the title Test suite must actually build fonts Test suite must actually build some fonts Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant