Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Emitter test might not be working as expected #31

Open
rjmccluskey opened this issue May 9, 2016 · 0 comments
Open

Event Emitter test might not be working as expected #31

rjmccluskey opened this issue May 9, 2016 · 0 comments

Comments

@rjmccluskey
Copy link

https://github.com/thelgevold/angular-2-samples/blob/master/unit-test-scenarios/event-emitter/event-emitter-spec.ts

I was using the example you have on testing an EventEmitter and I discovered that my test was passing because the test runner could not find an expectation. Try changing the expect inside the subscription to be something you know will fail (like expect false to equal true) and your test might still come back that it passed.

Maybe I just have something setup incorrectly so I'm sorry if I'm wrong about this but I just wanted to give you a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant