Skip to content

ssamal2801 - issue#17 - fixed image error with base url #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ssamal2801
Copy link

@ssamal2801 ssamal2801 commented Jan 4, 2024

The issue you were facing was that when you were changing the base URL in the Next.js config file in step one of your issue description, you were changing the root directory of the project.

For this reason, the images are now available at "/apps/materio/images...." instead of "/images...".

I have corrected the image url and both the next.js config files.

Now your served files should work as expected with images.
You do not need to change the base route every time you switch between local or remote NGINX servers. You can access them both at the same base route:

Example:

  • For local - localhost:3000/apps/materio (instead of localhost:3000/)
  • and for NGINX - 128.3.4.5:8900/apps/materio (instead of 128.3.4.5:8900)

image

image

@neelbrahmakshatriya
Copy link
Member

Hi @ssamal2801,

Thanks for showing an interest in contributing.

Most of the users might not need this change in their apps. If someone does this, the app will not work at http://localhost:3000 URL.

Thus, we are not considering merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants