Skip to content

Commit c2ccac1

Browse files
committed
fix: eslint and add prettier
1 parent fe88472 commit c2ccac1

File tree

5 files changed

+312
-16
lines changed

5 files changed

+312
-16
lines changed

.eslintrc.cjs

+9-6
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
module.exports = {
22
root: true,
33
env: { browser: true, es2020: true },
4-
extends: [
5-
"eslint:recommended",
6-
"plugin:@typescript-eslint/recommended",
7-
"plugin:react-hooks/recommended",
4+
extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
5+
ignorePatterns: [
6+
"**/node_modules/",
7+
"**/dist/",
8+
"**/public/",
9+
".eslintrc.cjs",
810
],
9-
ignorePatterns: ["**/node_modules/", "**/dist/", "**/public/"],
1011
parser: "@typescript-eslint/parser",
1112
parserOptions: {
12-
project: "tsconfig.eslint.json",
13+
project: ["frontend/tsconfig.json", "cli/tsconfig.json"],
1314
tsconfigRootDir: __dirname,
1415
sourceType: "module",
1516
},
@@ -23,6 +24,7 @@ module.exports = {
2324
"risxss",
2425
"testing-library",
2526
"react-refresh",
27+
"prettier",
2628
],
2729
rules: {
2830
"import/extensions": 0,
@@ -34,6 +36,7 @@ module.exports = {
3436
"max-depth": ["error", 3],
3537
"max-params": ["error", 4],
3638
eqeqeq: ["error", "smart"],
39+
"prettier/prettier": "error",
3740
"import/no-extraneous-dependencies": [
3841
"error",
3942
{

cli/index.ts

+24-9
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
import parseArgs from 'minimist';
1+
import parseArgs from "minimist";
22

33
enum Providers {
4-
GITHUB = 'github',
4+
GITHUB = "github",
55
}
66

7+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
78
interface Workflow {
89
id: number;
910
jobs_url: string;
@@ -13,6 +14,7 @@ interface Workflow {
1314
created_at: string;
1415
}
1516

17+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
1618
interface Job {
1719
total_count: number;
1820
workflow: {
@@ -32,21 +34,34 @@ interface Job {
3234
}[];
3335
}
3436

37+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
3538
interface ScriptParameters {
3639
saveCsv: boolean;
3740
}
3841

39-
const getParameters = (
40-
env: Record<string, unknown>
41-
): { owner: string, repo: string, token: string, max: number, provider: Providers } => {
42-
const { owner, repo, token, max, provider } = parseArgs(process.argv, { alias: { o: 'owner', r: 'repo', t: 'token', m: 'max', p: 'provider' }, string: ['owner', 'repo', 'token', 'max'], default: { provider: Providers.GITHUB } });
42+
interface Config {
43+
owner: string;
44+
repo: string;
45+
token: string;
46+
max: number;
47+
provider: Providers;
48+
}
49+
50+
const getParameters = (): Config => {
51+
const { owner, repo, token, max, provider } = parseArgs<
52+
Omit<Config, "max"> & { max: string }
53+
>(process.argv, {
54+
alias: { o: "owner", r: "repo", t: "token", m: "max", p: "provider" },
55+
string: ["owner", "repo", "token", "max"],
56+
default: { provider: Providers.GITHUB },
57+
});
4358

4459
if (
4560
owner !== "" &&
4661
repo !== "" &&
4762
token !== "" &&
4863
max !== "" &&
49-
!isNaN(parseInt(max)) &&
64+
!isNaN(parseInt(max)) &&
5065
Object.values(Providers).includes(provider)
5166
) {
5267
return { owner, repo, token, max: parseInt(max), provider };
@@ -57,7 +72,7 @@ const getParameters = (
5772

5873
const { owner, repo, token, max, provider } = getParameters(process.env);
5974

60-
if (provider !== Providers.GITHUB) {
75+
if (provider !== Providers.GITHUB) {
6176
throw new Error("Only github is supported for now");
6277
}
6378

@@ -69,4 +84,4 @@ const MAX_NUMBER_OF_NEW_WORKFLOWS = max;
6984

7085
const doAll = async () => {};
7186

72-
void doAll();
87+
void doAll();

cli/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"author": "",
1414
"license": "ISC",
1515
"dependencies": {
16+
"@types/minimist": "^1.2.5",
1617
"minimist": "^1.2.8"
1718
},
1819
"devDependencies": {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"format-check": "prettier --check .",
1515
"format-fix": "prettier --write ."
1616
},
17-
"dependencies": {},
1817
"devDependencies": {
1918
"@typescript-eslint/eslint-plugin": "^6.10.0",
2019
"@typescript-eslint/parser": "^6.10.0",
@@ -23,6 +22,7 @@
2322
"eslint-plugin-jest": "^27.6.0",
2423
"eslint-plugin-jsx-a11y": "^6.8.0",
2524
"eslint-plugin-prefer-arrow": "^1.2.3",
25+
"eslint-plugin-prettier": "^5.0.1",
2626
"eslint-plugin-react": "^7.33.2",
2727
"eslint-plugin-react-hooks": "^4.6.0",
2828
"eslint-plugin-react-refresh": "^0.4.4",

0 commit comments

Comments
 (0)