Merge pull request #65 from PatronBase/master

Add pending transaction support

Author: greydnls

src/Message/AbstractRequest.php

@@ -30,7 +30,7 @@
  */
 abstract class AbstractRequest extends \Omnipay\Common\Message\AbstractRequest
 {
-    const API_VERSION = '85.0';
+    const API_VERSION = '119.0';
 
     protected $liveEndpoint = 'https://api-3t.paypal.com/nvp';
     protected $testEndpoint = 'https://api-3t.sandbox.paypal.com/nvp';

src/Message/Response.php

@@ -16,6 +16,12 @@ public function __construct(RequestInterface $request, $data)
         parse_str($data, $this->data);
     }
 
+    public function isPending()
+    {
+        return isset($this->data['PAYMENTINFO_0_PAYMENTSTATUS'])
+            && $this->data['PAYMENTINFO_0_PAYMENTSTATUS'] == 'Pending';
+    }
+
     public function isSuccessful()
     {
         return isset($this->data['ACK']) && in_array($this->data['ACK'], array('Success', 'SuccessWithWarning'));

tests/ExpressGatewayTest.php

@@ -44,6 +44,7 @@ public function testAuthorizeSuccess()
         $response = $this->gateway->authorize($this->options)->send();
 
         $this->assertInstanceOf('\Omnipay\PayPal\Message\ExpressAuthorizeResponse', $response);
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertTrue($response->isRedirect());
         $this->assertEquals('https://www.paypal.com/cgi-bin/webscr?cmd=_express-checkout&useraction=commit&token=EC-42721413K79637829', $response->getRedirectUrl());
@@ -55,6 +56,7 @@ public function testAuthorizeFailure()
 
         $response = $this->gateway->authorize($this->options)->send();
 
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertFalse($response->isRedirect());
         $this->assertNull($response->getTransactionReference());
@@ -68,6 +70,7 @@ public function testPurchaseSuccess()
         $response = $this->gateway->purchase($this->options)->send();
 
         $this->assertInstanceOf('\Omnipay\PayPal\Message\ExpressAuthorizeResponse', $response);
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertTrue($response->isRedirect());
         $this->assertEquals('https://www.paypal.com/cgi-bin/webscr?cmd=_express-checkout&useraction=commit&token=EC-42721413K79637829', $response->getRedirectUrl());
@@ -79,6 +82,7 @@ public function testPurchaseFailure()
 
         $response = $this->gateway->purchase($this->options)->send();
 
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertFalse($response->isRedirect());
         $this->assertNull($response->getTransactionReference());

tests/Message/ExpressAuthorizeResponseTest.php

@@ -21,6 +21,7 @@ public function testExpressPurchaseSuccess()
         $request->shouldReceive('getTestMode')->once()->andReturn(true);
         $response = new ExpressAuthorizeResponse($request, $httpResponse->getBody());
 
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertSame('EC-42721413K79637829', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
@@ -34,6 +35,7 @@ public function testExpressPurchaseFailure()
         $httpResponse = $this->getMockHttpResponse('ExpressPurchaseFailure.txt');
         $response = new ExpressAuthorizeResponse($this->getMockRequest(), $httpResponse->getBody());
 
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertNull($response->getTransactionReference());
         $this->assertNull($response->getTransactionReference());

tests/Message/ExpressFetchCheckoutRequestTest.php

@@ -54,6 +54,7 @@ public function testSendSuccess()
         $this->setMockHttpResponse('ExpressFetchCheckoutSuccess.txt');
 
         $response = $this->request->send();
+        $this->assertFalse($response->isPending());
         $this->assertTrue($response->isSuccessful());
         $this->assertFalse($response->isRedirect());
     }
@@ -63,6 +64,7 @@ public function testSendFailure()
         $this->setMockHttpResponse('ExpressFetchCheckoutFailure.txt');
 
         $response = $this->request->send();
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertFalse($response->isRedirect());
         $this->assertSame('The amount exceeds the maximum amount for a single transaction.', $response->getMessage());

tests/Message/ResponseTest.php

@@ -18,6 +18,7 @@ public function testProPurchaseSuccess()
         $httpResponse = $this->getMockHttpResponse('ProPurchaseSuccess.txt');
         $response = new Response($this->getMockRequest(), $httpResponse->getBody());
 
+        $this->assertFalse($response->isPending());
         $this->assertTrue($response->isSuccessful());
         $this->assertSame('96U93778BD657313D', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
@@ -28,6 +29,7 @@ public function testProPurchaseFailure()
         $httpResponse = $this->getMockHttpResponse('ProPurchaseFailure.txt');
         $response = new Response($this->getMockRequest(), $httpResponse->getBody());
 
+        $this->assertFalse($response->isPending());
         $this->assertFalse($response->isSuccessful());
         $this->assertNull($response->getTransactionReference());
         $this->assertSame('This transaction cannot be processed. Please enter a valid credit card expiration year.', $response->getMessage());