Skip to content

Commit b37df52

Browse files
AlexZ005claude
andcommitted
54-int: battery reds from the union's own intended changes -- z-scale accepts a window held below the top chrome on a tablet-wide screen (54 f); sheet-handoff tests hand-off only on a list long enough to absorb it (Explorer empty state + Add files overflows a short sheet by ~40 px)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 787018e commit b37df52

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎tests/e2e/sheet-handoff.test.cjs‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,10 @@ h.run(async () => {
183183
* a dock tab's frame also holds the panel's header, which has nothing to scroll) */
184184
const inY = (y) => Math.max(bodyR ? bodyR.top + 12 : s0.top + 40, Math.min(s0.bottom - 12, y));
185185
const sc = await scrollerAt(bx, by);
186-
const scrolls = !!sc && sc.max > 30;
186+
// 54-int: a list must be able to ABSORB the gestures below (step 1 asks for > 40 px of scroll, the hand-back
187+
// travels ~130 px past the start); a body that scrolls only a little (the Explorer's empty state with its
188+
// "Add files…" button, 81 X1, overflows a 248 px sheet by ~40 px) hands the rest to the sheet by design
189+
const scrolls = !!sc && sc.max > 140;
187190
// --- 1. drag UP on the list: the list scrolls, the sheet stays ---
188191
if (scrolls) {
189192
await setProbeTop(0);
@@ -202,7 +205,7 @@ h.run(async () => {
202205
h.check(s2 && Math.abs(s2.h - s0.h) < 4, `${name}: ...and does not move the sheet (${Math.round(s0.h)} -> ${Math.round(s2?.h ?? 0)})`);
203206
h.check((await probeTop()) < before, `${name}: ...the list scrolled back toward its top (${before} -> ${await probeTop()})`);
204207
} else {
205-
h.check(true, `${name}: its body does not scroll at this height (${JSON.stringify(sc)}) — the body is the sheet`);
208+
h.check(true, `${name}: its body does not scroll (far) at this height (${JSON.stringify(sc)}) — the body is the sheet`);
206209
}
207210
// --- 3. at the top: a slow drag down moves the SHEET with the finger ---
208211
if (scrolls) await setProbeTop(0);

‎tests/e2e/z-scale-layering.test.cjs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,14 @@ h.run(async () => {
121121
const y = r.top + r.height / 2;
122122
const w = /** @type {HTMLElement} */ (document.querySelector('#whats-new-window'));
123123
const wr = w.getBoundingClientRect();
124-
// a desktop window is clamped below the top bar (dragWindow), so it may simply not reach the logo
125-
if (x < wr.left || x > wr.right || y < wr.top || y > wr.bottom) return 'not under the window';
124+
// a window is clamped below the top chrome (dragWindow's topChromeFloor: desktop, and since 54 f a
125+
// tablet-wide screen too), so it may simply not reach the logo -- only when it was HELD down (top > 0)
126+
if (x < wr.left || x > wr.right || y < wr.top || y > wr.bottom) return wr.top > 0 ? 'not under the window' : 'missed the logo at top 0';
126127
const hit = document.elementFromPoint(x, y);
127128
return w.contains(hit) ? 'covered' : hit?.id || hit?.tagName;
128129
});
129130
h.check(
130-
logoUnder === 'covered' || (dev === 'desktop' && logoUnder === 'not under the window'),
131+
logoUnder === 'covered' || (dev !== 'folded' && logoUnder === 'not under the window'),
131132
`${dev}: where What's new overlaps the logo, a press lands in What's new (${logoUnder})`
132133
);
133134
// and its own close still works by a real click

0 commit comments

Comments
 (0)