From cc9013b3b03a0a1e1f4ac5f74f47697512cae59d Mon Sep 17 00:00:00 2001 From: Sujit Kumar <60378235+therealsujitk@users.noreply.github.com> Date: Tue, 14 Nov 2023 20:25:26 +0530 Subject: [PATCH] Fix offset issue for unapproved students (#57) --- .../vtopchennai/services/VTOPService.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/tk/therealsuji/vtopchennai/services/VTOPService.java b/app/src/main/java/tk/therealsuji/vtopchennai/services/VTOPService.java index a6b4809..743000d 100644 --- a/app/src/main/java/tk/therealsuji/vtopchennai/services/VTOPService.java +++ b/app/src/main/java/tk/therealsuji/vtopchennai/services/VTOPService.java @@ -801,7 +801,6 @@ private void downloadCourses() { " }" + " var table = doc.getElementById('studentDetailsList').getElementsByTagName('table')[0];" + " var headings = table.getElementsByTagName('th');" + - " var offset = headings[0].innerText.toLowerCase().includes('invoice') ? -1 : 0;" + " var courseIndex, creditsIndex, slotVenueIndex, facultyIndex;" + " for(var i = 0; i < headings.length; ++i) {" + " var heading = headings[i].innerText.toLowerCase();" + @@ -816,6 +815,9 @@ private void downloadCourses() { " }" + " }" + " var cells = table.getElementsByTagName('td');" + + " var headingOffset = headings[0].innerText.toLowerCase().includes('invoice') ? -1 : 0;" + + " var cellOffset = cells[0].innerText.toLowerCase().includes('invoice') ? 1 : 0;" + + " var offset = headingOffset + cellOffset;" + " while (courseIndex < cells.length && creditsIndex < cells.length && slotVenueIndex < cells.length && facultyIndex < cells.length) {" + " var course = {};" + " var rawCourse = cells[courseIndex + offset].innerText.replace(/\\t/g,'').replace(/\\n/g,' ');" + @@ -831,10 +833,10 @@ private void downloadCourses() { " course.venue = rawSlotVenue.slice(1, rawSlotVenue.length).join(' - ').trim();" + " course.faculty = rawFaculty[0].trim();" + " response.courses.push(course);" + - " courseIndex += headings.length + offset;" + - " creditsIndex += headings.length + offset;" + - " slotVenueIndex += headings.length + offset;" + - " facultyIndex += headings.length + offset;" + + " courseIndex += headings.length + headingOffset;" + + " creditsIndex += headings.length + headingOffset;" + + " slotVenueIndex += headings.length + headingOffset;" + + " facultyIndex += headings.length + headingOffset;" + " }" + " }" + "});" +