Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many permissions? #113

Open
jvolker opened this issue Apr 19, 2016 · 1 comment
Open

Too many permissions? #113

jvolker opened this issue Apr 19, 2016 · 1 comment

Comments

@jvolker
Copy link

jvolker commented Apr 19, 2016

I wonder if all of these permissions are really necessary and if so, why?:
image

Especially:

  • write all personal data
  • read and write all repositories

It kind of scared me away in the first place, until I created another test account on Github.

I would also be interested to know how and where the app saves my uploaded examples?

@therewasaguy
Copy link
Owner

therewasaguy commented Apr 19, 2016

@jvolker you're right that we don't really need all of these permissions.

Originally I experimented with hosting projects through secret GitHub Gists, with the idea that eventually we might move to hosting all projects on GitHub, as either public or private repos. Wound up not going that route, and if the permissions are scaring you I imagine you're not the only one so might as well scale it back.

In the long run users should be able to log in by multiple methods. The priority is a simple way to create an account with an email address + password

This is where we set the scope of permissions and these are the different options:
https://developer.github.com/v3/oauth/#scopes

The simplest would be to limit to user:email.

As far as where data is saved, it's stored in a MongoDB, currently hosted through mlab as mentioned in #112. In the long run it might make more sense to experiment with static hosting on Amazon S3, as discussed in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants