fix(bitmap): decoder was decoding bitmaps with leading false incorrectly (#14)

* fix(bitmap): decoder was decoding bitmaps with leading false incorrectly

#13

* fix gopath

* Revert "fix gopath"

This reverts commit 8b538ed.

* GOPATH fixes

* more fixes

* chore: build fixes

* chore: lcov

* chore: build fixes

* use apt addon

* reinit semantic release

Author: joscha

.travis.yml

@@ -1,4 +1,8 @@
 language: node_js
+addons:
+  apt:
+    packages:
+      - lcov
 cache:
   yarn: true
   directories:
@@ -8,10 +12,9 @@ notifications:
 node_js:
   - stable
 before_install:
-  - export GOPATH="${TRAVIS_BUILD_DIR}/Godeps/_workspace:$GOPATH"
+  - export GOPATH="${TRAVIS_BUILD_DIR}/Godeps/_workspace"
   - export PATH="${TRAVIS_BUILD_DIR}/Godeps/_workspace/bin:$PATH"
   - go get -v github.com/robertkrimen/otto/otto # Download otto JS interpreter
-  - sudo apt-get install lcov
 script:
   - yarn lint
   - FORCE_COLOR=true yarn test

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lora-serialization",
-  "version": "3.0.0",
+  "version": "0.0.0-development",
   "description": "LoraWAN serialization/deserialization library for The Things Network",
   "main": "src/index.js",
   "directories": {
@@ -38,7 +38,7 @@
     "eslint": "^3.0.1",
     "lcov-result-merger": "^1.2.0",
     "nyc": "^10.1.2",
-    "semantic-release": "^6.3.2"
+    "semantic-release": "^6.3.6"
   },
   "config": {
     "commitizen": {

src/decoder.js

@@ -82,7 +82,7 @@ var bitmap = function(byte) {
     throw new Error('Bitmap must have exactly 1 byte');
   }
   var i = bytesToInt(byte);
-  var bm = Number(i).toString(2).split('').map(Number).map(Boolean);
+  var bm = ('00000000' + Number(i).toString(2)).substr(-8).split('').map(Number).map(Boolean);
   return ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h']
     .reduce(function(obj, pos, index) {
       obj[pos] = bm[index];

test/base.js

@@ -25,4 +25,15 @@ module.exports = {
     h: true
   },
   bitmapBytes: new Buffer([253]),
+  bitmap2: {
+    a: false,
+    b: true,
+    c: false,
+    d: false,
+    e: false,
+    f: false,
+    g: false,
+    h: false
+  },
+  bitmap2Bytes: new Buffer([64]),
 };

test/decoder/bitmap.js

@@ -14,3 +14,7 @@ test('should be possible to decode a bitmap', t => {
   t.deepEqual(decoder.bitmap(base.bitmapBytes), base.bitmap);
   t.pass();
 });
+test('should be possible to decode a bitmap with leading false', t => {
+  t.deepEqual(decoder.bitmap(base.bitmap2Bytes), base.bitmap2);
+  t.pass();
+});