Skip to content

Commit 2710dd2

Browse files
Changing all Logger.info to Logger.debug (#5)
1 parent 7a64912 commit 2710dd2

File tree

8 files changed

+13
-40
lines changed

8 files changed

+13
-40
lines changed

CHANGELOG.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
# CHANGELOG (v0.1.2)
1+
# CHANGELOG (v0.1.3)
22

3-
## 0.1.2 (2025-08-02)
3+
## 0.1.3 (2025-08-02)
44

5-
### Backwards incompatible changes for 0.1.0
5+
### Backwards incompatible changes for 0.1.2
66
* None
77

88
### Bug fixes
99
* None
1010

1111
### Enhancements
12-
* Downgrade Elixir version and Phoenix liveview to allow more projects to hook in this library
13-
* [[`PR-4`](https://github.com/observer_web/deployex/pull/4)] Adding Filtering for tracing modules/functions
12+
* Adjusted Logger messages
1413

1514
# Previous Releases
15+
* [0.1.2 🚀 (2025-01-06)](https://github.com/thiagoesteves/observer_web/blob/v0.1.2/CHANGELOG.md)
1616
* [0.1.0 🚀 (2025-01-06)](https://github.com/thiagoesteves/observer_web/blob/v0.1.0/CHANGELOG.md)

lib/observer_web/apps.ex

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ defmodule ObserverWeb.Apps do
66
* https://github.com/shinyscorpion/wobserver
77
"""
88

9-
require Logger
10-
119
alias ObserverWeb.Apps.Helper
1210
alias ObserverWeb.Rpc
1311

@@ -257,7 +255,6 @@ defmodule ObserverWeb.Apps do
257255
# coveralls-ignore-start
258256
def new(%{id: id} = attrs) do
259257
name = "#{inspect(id)}"
260-
Logger.warning("Entity ID not mapped: #{name}")
261258

262259
struct(
263260
__MODULE__,

lib/observer_web/tracer.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ defmodule ObserverWeb.Tracer do
66
* https://github.com/thiagoesteves/deployex/blob/main/lib/deployex/tracer.ex
77
"""
88

9-
require Logger
10-
119
alias ObserverWeb.Rpc
1210
alias ObserverWeb.Tracer.Server, as: TServer
1311

lib/observer_web/tracer/server.ex

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ defmodule ObserverWeb.Tracer.Server do
2424

2525
@impl true
2626
def init(_args) do
27-
Logger.info("Initializing Tracing Server")
2827
{:ok, %Tracer{}}
2928
end
3029

@@ -33,8 +32,6 @@ defmodule ObserverWeb.Tracer.Server do
3332
session_id: session_id
3433
})
3534
when rcv_session_id == session_id do
36-
Logger.info("The Trace session_id: #{inspect(session_id)} was requested to stop.")
37-
3835
:dbg.stop()
3936

4037
{:reply, :ok, %Tracer{}}
@@ -71,8 +68,6 @@ defmodule ObserverWeb.Tracer.Server do
7168
) do
7269
Process.monitor(request_pid)
7370

74-
Logger.info("New Trace Session: #{session_id} functions: #{inspect(functions_by_node)}")
75-
7671
tracer_pid = self()
7772
# The local node is always present in the trace list of nodes.
7873
# The following list will indicate to the trace handler whether the node
@@ -138,8 +133,6 @@ defmodule ObserverWeb.Tracer.Server do
138133
request_pid: request_pid
139134
})
140135
when rcv_session_id == session_id do
141-
Logger.info("The Trace session_id: #{inspect(session_id)} timed out")
142-
143136
:dbg.stop()
144137

145138
send(request_pid, msg)
@@ -154,12 +147,10 @@ defmodule ObserverWeb.Tracer.Server do
154147
# NOTE: Messages from handle_trace
155148
def handle_info({:stop_tracing, rcv_session_id} = msg, %Tracer{
156149
session_id: session_id,
157-
max_messages: max_messages,
150+
max_messages: _max_messages,
158151
request_pid: request_pid
159152
})
160153
when rcv_session_id == session_id do
161-
Logger.info("Max messages (#{max_messages}) reached for session: #{inspect(session_id)}.")
162-
163154
send(request_pid, msg)
164155

165156
{:noreply, %Tracer{}}
@@ -175,8 +166,6 @@ defmodule ObserverWeb.Tracer.Server do
175166
%{request_pid: request_pid}
176167
)
177168
when target_pid == request_pid do
178-
Logger.warning("target process was terminated")
179-
180169
:dbg.stop()
181170

182171
{:noreply, %Tracer{}}

lib/web/pages/apps/page.ex

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ defmodule Observer.Web.Apps.Page do
77

88
use Observer.Web, :live_component
99

10-
require Logger
11-
1210
alias Observer.Web.Apps.Legend
1311
alias Observer.Web.Apps.Port
1412
alias Observer.Web.Apps.Process
@@ -352,8 +350,6 @@ defmodule Observer.Web.Apps.Page do
352350
|> String.to_charlist()
353351
|> :erlang.list_to_pid()
354352

355-
Logger.info("Retrieving process info for pid: #{request_id}")
356-
357353
%{
358354
info: Apps.Process.info(pid),
359355
id_string: request_id,
@@ -371,8 +367,6 @@ defmodule Observer.Web.Apps.Page do
371367

372368
node = String.to_existing_atom(service)
373369

374-
Logger.info("Retrieving port info for port: #{request_id}")
375-
376370
%{
377371
info: Apps.Port.info(node, port),
378372
id_string: request_id,

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ defmodule ObserverWeb.MixProject do
22
use Mix.Project
33

44
@source_url "https://github.com/thiagoesteves/observer_web"
5-
@version "0.1.2"
5+
@version "0.1.3"
66

77
def project do
88
[

test/observer_web/tracer_test.exs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ defmodule ObserverWeb.TracerTest do
22
use ExUnit.Case, async: true
33

44
import Mox
5-
import ExUnit.CaptureLog
65

76
alias ObserverWeb.Tracer
87
alias ObserverWeb.TracerFixtures
@@ -307,16 +306,14 @@ defmodule ObserverWeb.TracerTest do
307306
}
308307
]
309308

310-
assert capture_log(fn ->
311-
spawn(fn ->
312-
{:ok, %{session_id: _session_id}} =
313-
Tracer.start_trace(functions, %{max_messages: 20})
314-
end)
309+
spawn(fn ->
310+
{:ok, %{session_id: _session_id}} =
311+
Tracer.start_trace(functions, %{max_messages: 20})
312+
end)
315313

316-
:timer.sleep(50)
314+
:timer.sleep(50)
317315

318-
assert %Tracer{status: :idle} = Tracer.state()
319-
end) =~ "target process was terminated"
316+
assert %Tracer{status: :idle} = Tracer.state()
320317
end
321318

322319
defp terminate_tracing(session_id) do

test/observer_web/web/live/tracing_test.exs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,6 @@ defmodule Observer.Web.TracingLiveTest do
325325
index_live
326326
|> element("#tracing-multi-select-stop", "STOP")
327327
|> render_click()
328-
329-
assert render(index_live) =~ "Enum."
330328
end
331329

332330
test "Observer timing out", %{conn: conn} do

0 commit comments

Comments
 (0)