[SDK] Improve add/removeContract method for registry.ts (#1731)

Author: kien-ngo

.changeset/cuddly-gorillas-cheer.md

@@ -0,0 +1,5 @@
+---
+"@thirdweb-dev/sdk": patch
+---
+
+Improve add/removeContract methods

packages/sdk/src/evm/core/classes/registry.ts

@@ -48,15 +48,11 @@ export class ContractRegistry extends ContractWrapper<TWRegistry> {
     ): Promise<Transaction<TransactionResult>> => {
       const deployerAddress = await this.getSignerAddress();
       const contractEncoder = new ContractEncoder(this);
-      const encoded: string[] = await Promise.all(
-        contractAddresses.map(async (address) =>
-          contractEncoder.encode("add", [
-            deployerAddress,
-            await resolveAddress(address),
-          ]),
-        ),
+      const encoded = (
+        await Promise.all(contractAddresses.map((addr) => resolveAddress(addr)))
+      ).map((address) =>
+        contractEncoder.encode("add", [deployerAddress, address]),
       );
-
       return Transaction.fromContractWrapper({
         contractWrapper: this,
         method: "multicall",
@@ -79,15 +75,11 @@ export class ContractRegistry extends ContractWrapper<TWRegistry> {
     ): Promise<Transaction<TransactionResult>> => {
       const deployerAddress = await this.getSignerAddress();
       const contractEncoder = new ContractEncoder(this);
-      const encoded: string[] = await Promise.all(
-        contractAddresses.map(async (address) =>
-          contractEncoder.encode("remove", [
-            deployerAddress,
-            await resolveAddress(address),
-          ]),
-        ),
+      const encoded = (
+        await Promise.all(contractAddresses.map((addr) => resolveAddress(addr)))
+      ).map((address) =>
+        contractEncoder.encode("remove", [deployerAddress, address]),
       );
-
       return Transaction.fromContractWrapper({
         contractWrapper: this,
         method: "multicall",