Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update to latest angular ivy library. #23

Open
leo6104 opened this issue Dec 8, 2022 · 1 comment
Open

Please update to latest angular ivy library. #23

leo6104 opened this issue Dec 8, 2022 · 1 comment

Comments

@leo6104
Copy link

leo6104 commented Dec 8, 2022

It seems angular-scrollspy still use ViewEngine library.

In latest angular and modern angular versions, they drop ViewEngine library build and recommend to use ivy compile library pattern.

It is easy to update.

Just put enableIvy in tsconfig.json

I can make PR for this updates. Please consider it.
@jamesjwarren
Copy link
Member

Thanks for showing interest in our angular-scrollspy library, we're not actively maintaining this package at the moment but we'd be more than happy to accept a PR for the necessary updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesjwarren @leo6104