Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tutorial, missing an argument in a function... #85

Open
totty90 opened this issue Sep 23, 2013 · 2 comments
Open

Wrong tutorial, missing an argument in a function... #85

totty90 opened this issue Sep 23, 2013 · 2 comments
Labels

Comments

@totty90
Copy link

totty90 commented Sep 23, 2013

At http://backbonetutorials.com/organizing-backbone-using-modules/

define([
'jquery',
'underscore',
'backbone',
'views/projects/list',
'views/users/list'
], function($, _, Backbone, Session, ProjectListView, UserListView){

Is wrong because the Session is not loaded.

Also in the same page: http://backbonetutorials.com/organizing-backbone-using-modules/

app_router.on('showProjects', function(){

should be

app_router.on('route:showProjects', function(){

see more here: http://stackoverflow.com/questions/14410242/backbone-router-doesnt-work-with-requirejs

@headwinds
Copy link
Collaborator

Ok yes, good catch. Thomas just needs to fix the tutorial to match the source - just remove Session and add the route as you described.

It's actually correct in the github source ;-D

@headwinds
Copy link
Collaborator

Actually... would you mind updating the code yourself? Then make a pull request and you'll get a nice contribution credit.

totty90 added a commit to totty90/backbonetutorials that referenced this issue Oct 21, 2013
The events fired by the app router have a "route:" prefix. (as explained here http://stackoverflow.com/questions/14410242/backbone-router-doesnt-work-with-requirejs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants