Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_empty in Sections view #433

Open
woniol opened this issue Apr 3, 2024 · 14 comments
Open

show_empty in Sections view #433

woniol opened this issue Apr 3, 2024 · 14 comments

Comments

@woniol
Copy link

woniol commented Apr 3, 2024

If show_empty is set to false, card is shown in the Sections view, taking additional space.
Not sure if this is for auto-entities card or the new Sections view case?

@woniol woniol changed the title Show if empty in Sections view show_empty in Sections view Apr 3, 2024
@luisleonardo
Copy link

I can confirm and provide a screenshot.

The space in the middle is created by 6 card with "show_empty: false".

image

@Drun555
Copy link

Drun555 commented May 6, 2024

These gaps driving me crazy. It seems more like Sections bug due same situation with conditional card right now.

🙏
IMG_6983

@luisleonardo
Copy link

Any news? I still can't use the sections due to this bug and I don't even know if the problem is from auto-entities or Lovelace :(

@spartan117aut
Copy link

spartan117aut commented Jun 5, 2024

Hi @thomasloven,
I have the same problem. The problem with conditional cards has been fixed here, but empty auto-entities cards still occupy space. See attached screenshots.

Edit mode:
image

Actual display:
image

@igorsantos07
Copy link

I was going to open a bug on HA, as a follow-up to home-assistant/frontend#20352 (where they state the solution for the problem is using the new Visibility option, but that effectively causes us to recreate and duplicate the filters from auto-entities; not a solution). My thesis was that they should reduce --row-height and/or make it themeable, so we can fix it for our specific scenarios...

However, while writing it, I realize the default entities-filter does not show this behavior. Thus, I guess this is a bug with this custom card, which should not generate an empty card component on the UI (instead of generating an empty one).
image

@skynet01
Copy link

skynet01 commented Sep 3, 2024

Any updates or solutions to fix this even if manually?

@christian1986
Copy link

Any news on this? Highly limit the usage of the card😕

@MrAdam
Copy link

MrAdam commented Sep 26, 2024

I've made a PR that fixes this issue - I hope @thomasloven has time to look at it 😄

@pmharris77
Copy link

@MrAdam It seems the latest version of HA has fixed this for me

@MrAdam
Copy link

MrAdam commented Oct 8, 2024

@MrAdam It seems the latest version of HA has fixed this for me

Same here! Well, that's great, since it looks like @thomasloven is not active at the moment 👍
I'll leave my PR though, as it makes the code mimmic how other components does it.

One thing I did notice, is that if it's empty, I can't see it in edit mode, which makes it hard to edit using the GUI.
I might look into that if this repo ever becomes active again 😄

@jackwilsdon
Copy link

jackwilsdon commented Nov 4, 2024

It looks like this is still an issue if a hidden auto-entities card is the only thing in a section:

image

The large gap in the top left is where the auto-entities card is.

@MrAdam
Copy link

MrAdam commented Nov 5, 2024

It looks like this is still an issue if a hidden auto-entities card is the only thing in a section:

image

The large gap in the top left is where the auto-entities card is.

Can you try the fix from my branch and see if it works? If yes, then maybe we should get it merged.

@sambarre
Copy link

sambarre commented Nov 5, 2024

I saw a mentioned in the thread that this was fixed by an update to HA itself, but I still seem to be having the issue
image
This gap in my vertical stack card is a few auto entities cards that are hidden most of the time

How would I go about testing this branch if I wanted to?

@jackwilsdon
Copy link

@MrAdam sadly it doesn't fix it.

image

image

Tried with the card both inside and outside a section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests