Skip to content

(change) Initialization of retrievers should also eventually call their specific initialization methods #4024

@DeamonDev

Description

@DeamonDev

Motivation

I observed the flow of initializing of some retrievers may be not complete. When we call InitRetriever method to spawn
s3 retriever then we internally call

func createS3Retriever(c *retrieverconf.RetrieverConf, _ time.Duration) (retriever.Retriever, error) {
	awsConfig, err := awsConf.LoadDefaultConfig(context.Background())
	return &s3retrieverv2.Retriever{Bucket: c.Bucket, Item: c.Item, AwsConfig: &awsConfig}, err
}

But there is also initialization method for s3 retriever.

Requirements

Discussion whether we should call specific init methods here or not

Metadata

Metadata

Labels

changeThis is a change in the code that should not affect the usersp2Medium priority

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions