Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window.set_on_close page #8

Open
DanRathbun opened this issue Jul 5, 2018 · 2 comments
Open

Window.set_on_close page #8

DanRathbun opened this issue Jul 5, 2018 · 2 comments

Comments

@DanRathbun
Copy link

WebDialog.set_on_close page would be helpful to warn of double calling (at least in SU 2016 on Windows.)

Ref ... UI::WebDialog set_on_close block is called twice

@thomthom
Copy link
Owner

thomthom commented Jul 9, 2018

I've not been able to reproduce that. (See linked issue.)

@DanRathbun
Copy link
Author

This was actually a circular code call. (Programmer error!) The LM should warn not to call close() from within the set_on_close() block or any code that it calls.

Ie, the API docs are not clear that the window is still visible, and will not actually be destroyed until the block finishes and set_on_close() returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants