Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #22

Open
Eneroth3 opened this issue Jan 12, 2018 · 1 comment
Open

Error handling #22

Eneroth3 opened this issue Jan 12, 2018 · 1 comment

Comments

@Eneroth3
Copy link
Contributor

As a new users I've done a few errors and was thinking it would be helpful with some improvements in error handling.

2018-01-12_18h06_01

If the library you are trying to install lacks a tag with version info you get an error message saying "Found no version ''" (first error in attached screenshot). I had to find the error in the Skippy source code to figure out what it meant. It would be very helpful if the message stated where Skippy expected to find a version of what, i.e. as a Git tag in the library.

Perhaps this could even just be a warning, not an error being raised. I noticed that if the versions defined in skippy.json and as a Git tag differed only a warning was given.

After adding the tag to my repo and trying again I got a second error (also seen in attached screenshot). It seems the last install attempt copied all the files over into the extension skippy/libs directory, even if the library wasn't added to the list in skippy.json, and later installing into a "dirty" directory causes a failure.

Maybe clearing the target directory of any files before installing a library could solve this?

@thomthom
Copy link
Owner

Yea, there is work to be done on error handling. Right now it's just a proof of concept - so the focus have been on the happy path. Once that has been refined attention will be made to catch failure cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants