Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil exit status? #12

Open
briankung opened this issue Sep 6, 2019 · 1 comment
Open

Nil exit status? #12

briankung opened this issue Sep 6, 2019 · 1 comment

Comments

@briankung
Copy link

briankung commented Sep 6, 2019

We are getting what seems to be a nil exit status (log says: ...returned . Expected 0 message from here in Terrapin: https://github.com/thoughtbot/terrapin/blob/master/lib/terrapin/command_line.rb#L92-L94), but we aren't completely sure what's going on.

It is an ImageMagick convert job. We are using the Terrapin ProcessRunner on Arch linux. Any tips would be helpful! I will also be opening a minor PR (#13) to inspect the exit status instead of depending on its to_s method.

Full Sentry error here: https://sentry.io/share/issue/9c19add2e75c4d2598ebb728ba477c32/

briankung added a commit to briankung/terrapin that referenced this issue Sep 6, 2019
For thoughtbot#12. This would be helpful to confirm that we are getting a `nil` exit status. Thanks!
@grncdr
Copy link

grncdr commented Jan 14, 2021

Hi @briankung, I'm also experiencing the same issue, and I suspect it's due to subprocesses (the convert process) being killed instead of exiting.

For the maintainers: a simple reproduction (on POSIX systems) is Terrapin::CommandLine.new('kill $$').run which simply kills the current shell.

elisuh pushed a commit to briankung/terrapin that referenced this issue Feb 16, 2023
For thoughtbot#12. This would be helpful to confirm that we are getting a `nil` exit status. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants