Naive retry in the Stellar client does not work and blocks the tx funding service if used by too many

[robvanmieghem]

In the Stellar client, if a transfer fails, it is retried up to 5 times without looking at the error that occurred.
If it's a timeout submitting to the Stellar network this most likely will not help since the Stellar ledger has not changed yet.
On top of this, this blocks 5 slave wallets in the transaction funding service ( well, they are reused but it might interfere with others).
The option is to increase the fee to try to get it included in the current ledger or wait until another ledger becomes available, or both

[rkhamis]

the transfer is retried 5 times to have the best shot at a successful deployment.
this is already a workaround because of the service unreliability.

@robvanmieghem what do you suggest instead? we already check if the service is up when we first start

[robvanmieghem]

The problem is not the service, the problem is the that the Stellar ledger is probably getting full. I mentioned the options above( wait for new ledger or increase the fee). The thing is that the current retry mechanism has a very small chance of success and impacts tx funding service stability ( through already used sequence numbers when too many clients use this)