Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution secret key need to be unique #3315

Open
sameh-farouk opened this issue Sep 15, 2021 · 0 comments
Open

solution secret key need to be unique #3315

sameh-farouk opened this issue Sep 15, 2021 · 0 comments
Projects
Milestone

Comments

@sameh-farouk
Copy link
Member

Description

some solutions use a secret key or similar configuration that should be set uniquely per solution and kept secret, using the default value intact from the values YAML file is considered risky, bad practice.

on some of the solutions (ex. Minio), the values for these secrets are generated via initContainers when not set.
but for other solutions, this is not the case, like in Mastodon, Taiga, and maybe others.

leaving the default values (ex. dummy, etc) is not an option as it is not unique nor secret, either asking the user for a random secret key or something like pair of signing keys is not an option too.

Implementation

my suggestion is to implement an extra step in the Chatflow with such functionality to generate these unique and random values then it overrides the secret values when do helm install.

@sameh-farouk sameh-farouk added this to Accepted in JS-SDK 11.6 via automation Sep 15, 2021
@sameh-farouk sameh-farouk moved this from Accepted to Backlog in JS-SDK 11.6 Sep 15, 2021
@xmonader xmonader added this to the later milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants