Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to js-ng 11.0b16 #3374

Open
abom opened this issue Sep 26, 2022 · 3 comments
Open

Update to js-ng 11.0b16 #3374

abom opened this issue Sep 26, 2022 · 3 comments
Assignees
Milestone

Comments

@abom
Copy link
Contributor

abom commented Sep 26, 2022

The build fails on python3.10, while it's fixed on js-ng

@abom
Copy link
Contributor Author

abom commented Sep 26, 2022

Make sure the build of older versions is passing in other workflows.

@abom abom self-assigned this Sep 26, 2022
@abom
Copy link
Contributor Author

abom commented Sep 29, 2022

Trying to update js-ng only by changing the version in pyproject.toml and then do poetry update js-ng didn't upgrade the dependency of greenlet (also doing something like poetry update js-ng greenlet gevent didn't work too).

Also, without modifying the pyproject.toml manually, I tried to do it using add command:

poetry add js-ng@latest

But, it didn't update greenlet again. Finally, I tried to pin the versions of greenlet and gevent too and it worked with

poetry add js-ng@latest greenlet@latest gevent@latest

All set? nope 😆
Installation went without issues, but running js-ng and trying a simple (but important quick test) of stellar client, I got the following error:

....
....
  File "/home/abom/projects/jumpscale/js-next/js-sdk/.venv/lib/python3.10/site-packages/stellar_sdk/strkey.py", line 91, in decode_ed25519_secret_seed
   raise Ed25519SecretSeedInvalidError(f"Invalid Ed25519 Secret Seed: {data}")

stellar_sdk.exceptions.Ed25519SecretSeedInvalidError: Invalid Ed25519 Secret Seed: XXXXXX

Invalid Ed25519 Secret Seed: XXXXXX

Trying to dig a little bit into decode_ed25519_secret_seed and add raise from to know the exact cause, and it showed:

...
...
  File "/home/abom/projects/jumpscale/js-next/js-sdk/.venv/lib/python3.10/site-packages/stellar_sdk/strkey.py", line 239, in _calculate_checksum
    checksum = crc16xmodem(payload)
               │           └ b'\x90\xc9..........'
               └ <built-in function crc16xmodem>

SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

And it turned out this error is just python 3.10 compatibility-related.
Will test newer stellar-sdk in an isolated environment, but I don't know If we can upgrade stellar-sdk for js-sdk or not.

@abom
Copy link
Contributor Author

abom commented Sep 29, 2022

After testing with stellar-sdk 8.1.0, I can load the key from secret as:

from stellar_sdk.keypair import Keypair
k = Keypair.from_secret("XXXXX")

@abom abom changed the title Update to js-ng 11.0b15 Update to js-ng 11.0b16 Oct 27, 2022
@xmonader xmonader added this to the 11.6 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants