-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error distributing cultivation rewards #834
Comments
we need to look into this and verify if this still happens |
Still didn't get confirmation from Ops so will move this to next milestone |
@coesensbert any update regarding this one if it is still happening? |
I was not involved in this, at least don't remember. But can help. What logs from where do you need? Or all recent qa-net tfchain logs and look for these references? |
You can grep this error from validators on QANet. |
val03 logs go back until 2024-02-26 grepped all the logs on no |
Can we check in mainNet and testNet as well please |
debug logs are not on there, is it required to see the cultivation logs? |
No |
I observed that on main net the logs are full of this errors which prevent Contracts from getting billed
|
to me it looks like it's trying to transfer out the minimal balance from an account and getting an error for that somehow. Also on another note, the locked balance calulcation currently implemented on tfchain is wrong. You should actually loop over the balance locks in storage to see how much is actually locked, see pub fn get_locked_balance(account_id: &T::AccountId) -> BalanceOf<T> {
let balance_locks = pallet_balances::pallet::Pallet::<T>::locks(account_id);
let mut locked_balance = BalanceOf::<T>::zero();
// loop over balance accumulate locked balance
for lock in balance_locks {
locked_balance +=
BalanceOf::<T>::saturated_from(lock.amount.saturated_into::<u128>());
}
locked_balance
} |
Thank you Dylan for your feedback. Yes I noted that before and opened an issue here #969 regarding the misuse of the balance lock |
Update: |
Seen on qanet:
The text was updated successfully, but these errors were encountered: