Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the stellar deposit tx hash in mintComlete event #882

Closed
sameh-farouk opened this issue Oct 30, 2023 · 1 comment · Fixed by #885
Closed

Include the stellar deposit tx hash in mintComlete event #882

sameh-farouk opened this issue Oct 30, 2023 · 1 comment · Fixed by #885
Assignees
@sameh-farouk
Labels
type_feature New feature or request
Milestone
2.7.0

Comments

@sameh-farouk
Copy link
Member

sameh-farouk commented Oct 30, 2023 •
edited
Loading

We need to include tx hash to the MintCompleted event for better observbility and event correlation in the bridge.
This will allow to instrument the system to use a common trace_id to stitch all related operation together to tell operators the whole story of a cross-chain transfer.

Context:
#874
@sameh-farouk sameh-farouk changed the title include the stellar deplost tx hash in mintComlete event Include the stellar deplost tx hash in mintComlete event Oct 30, 2023
@sameh-farouk sameh-farouk changed the title Include the stellar deplost tx hash in mintComlete event Include the stellar deposit tx hash in mintComlete event Oct 30, 2023
@sameh-farouk sameh-farouk moved this to Accepted in 3.13.x Oct 31, 2023
@sameh-farouk sameh-farouk added this to the 2.7.0 milestone Oct 31, 2023
This was referenced Nov 3, 2023
Closed
Merged
@renauter renauter assigned renauter and sameh-farouk and unassigned renauter Nov 6, 2023
@sameh-farouk sameh-farouk added the type_feature New feature or request label Nov 6, 2023
@sameh-farouk sameh-farouk moved this from Accepted to In Progress in 3.13.x Nov 7, 2023
@sameh-farouk sameh-farouk moved this from In Progress to Pending review in 3.13.x Nov 7, 2023
@sameh-farouk
Copy link
Member Author

Update:
PR: #885

@sameh-farouk sameh-farouk moved this from Pending review to In Progress in 3.13.x Nov 12, 2023
@sameh-farouk sameh-farouk moved this from In Progress to Pending review in 3.13.x Nov 12, 2023
@github-project-automation github-project-automation bot moved this from Pending review to Done in 3.13.x Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sameh-farouk sameh-farouk

Labels
type_feature New feature or request
Projects
No open projects
3.13.x
Status: Done
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Add tx hash to mintCompleted event threefoldtech/tfchain
2 participants
@sameh-farouk @renauter