-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move version chip to footer #3518
Conversation
<div class="mb-12 d-flex justify-center text-subtitle-2"> | ||
<p> | ||
© {{ new Date().getFullYear() }} ThreeFoldTech | ||
<span v-if="version !== 'No version to show'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to place 'No version to show' in a constant @AhmedHanafy725
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is to show the version to the user, if there is no version, there is no need to tell him that
@AhmedHanafy725 what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to place 'No version to show' in a constant @AhmedHanafy725
Done @amiraabouhadid can you check please
@ehab-hassan hey I actually meant declaring 'no current version to show' as an app wide constant as it is used in multiple places, not as a message string in a single component |
Description
the version chip overlaps with the sidebar extending so ll move it to footer
Changes
Move version chip to footer
Related Issues
#3514
Tested Scenarios
A list of scenarios tried to match the deliverables
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Checklist