From 4418f8c015fcc762e37eaa3aacb336bfab0f5cda Mon Sep 17 00:00:00 2001
From: throwaway96 <68320646+throwaway96@users.noreply.github.com>
Date: Sat, 3 Feb 2024 13:23:01 -0500
Subject: [PATCH] ci: merge build steps into reusable workflow

---
 .github/workflows/build.yml   | 60 +++++++++++++++++++++++++++++++++++
 .github/workflows/main.yml    | 31 ++----------------
 .github/workflows/release.yml | 34 +++++++-------------
 3 files changed, 75 insertions(+), 50 deletions(-)
 create mode 100644 .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
new file mode 100644
index 0000000..a692ee7
--- /dev/null
+++ b/.github/workflows/build.yml
@@ -0,0 +1,60 @@
+name: 'Build IPK and manifest'
+
+on:
+  workflow_call:
+    inputs:
+      fail-on-lint-error:
+        description: 'Fail on lint error'
+        required: false
+        default: false
+        type: boolean
+  workflow_dispatch:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Check out repo
+      uses: actions/checkout@v4
+      with:
+        submodules: recursive
+
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: 20
+        cache: 'npm'
+
+    - name: Install dependencies
+      run: npm ci
+
+    - name: Run lint
+      run: npm run lint
+      continue-on-error: ${{ github.event_name != 'workflow_call' || inputs.fail-on-lint-error }}
+
+    - name: Build frontend
+      run: npm run build -- --production
+
+    - name: Build service
+      run: npm run build-service -- --env production
+
+    - name: Create IPK
+      run: npm run package
+
+    - name: Create manifest
+      run: npm run manifest
+
+    - name: Upload IPK
+      uses: actions/upload-artifact@v4
+      with:
+        name: hbchannel-ipk
+        path: '*.ipk'
+        if-no-files-found: error
+
+    - name: Upload manifest
+      uses: actions/upload-artifact@v4
+      with:
+        name: hbchannel-manifest
+        path: '*.manifest.json'
+        if-no-files-found: error
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index c501a13..2275be7 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -9,31 +9,6 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        node-version: [20]
-        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
-
-    steps:
-    - uses: actions/checkout@v4
-      with:
-        submodules: recursive
-
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
-      with:
-        node-version: ${{ matrix.node-version }}
-
-    - run: npm ci
-    - run: npm run lint
-    - run: npm run build -- --production
-    - run: npm run build-service -- --env production
-    - run: npm run package
-    - run: 'echo "FILENAME_IPK=$(ls -- *.ipk)" >> "${GITHUB_ENV}"'
-    - name: Upload artifact
-      uses: actions/upload-artifact@v4
-      with:
-        name: hbchannel-ipk
-        path: ${{ github.workspace }}/${{ env.FILENAME_IPK }}
+    uses: ./.github/workflows/build.yml
+    with:
+      fail-on-lint-error: true
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 80120ca..f27eae3 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -5,29 +5,19 @@ on:
     types: [created]
 
 jobs:
-  build-and-release:
-    runs-on: ubuntu-latest
+  build:
+    uses: ./.github/workflows/build.yml
 
-    strategy:
-      matrix:
-        node-version: [20]
-        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+  release:
+    needs: build
+    runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v4
+    - name: Download artifacts
+      uses: actions/download-artifact@v4
       with:
-        submodules: recursive
-
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
-      with:
-        node-version: ${{ matrix.node-version }}
-
-    - run: npm ci
-    - run: npm run build -- --production
-    - run: npm run build-service -- --env production
-    - run: npm run package
-    - run: npm run manifest
+        pattern: 'hbchannel-*'
+        merge-multiple: true
 
     - name: Get release
       id: get_release
@@ -35,13 +25,13 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ github.token }}
 
-    - name: Upload Release assets
+    - name: Upload IPK
       uses: ncipollo/release-action@v1
       with:
-        token: ${{ secrets.GITHUB_TOKEN }}
         name: Release ${{ steps.get_release.outputs.tag_name }}
         allowUpdates: true
         omitNameDuringUpdate: true
         omitBodyDuringUpdate: true
+        omitDraftDuringUpdate: true
         omitPrereleaseDuringUpdate: true
-        artifacts: '*.ipk,org.webosbrew.hbchannel.manifest.json'
+        artifacts: '*.ipk,*.manifest.json'