Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm svg-pan-zoom instead of embedded one #15

Closed
3 tasks done
emeric254 opened this issue Feb 7, 2022 · 3 comments
Closed
3 tasks done

Use npm svg-pan-zoom instead of embedded one #15

emeric254 opened this issue Feb 7, 2022 · 3 comments

Comments

@emeric254
Copy link
Contributor

emeric254 commented Feb 7, 2022

Todo list :

  • find which version of svg-panzoom is currently used by this project
  • add svg-pan-zoom to this project dependencies (package.json)
  • test svg-pan-zoom new releases does not break anything

I'll try to come up with a PR to work on that

@emeric254
Copy link
Contributor Author

Ok seems there was no changes on svg-pan-zoom since 2019 so we're good in that way
(bumbu/svg-pan-zoom#395 and https://github.com/bumbu/svg-pan-zoom/releases)

@gr1m1um
Copy link
Collaborator

gr1m1um commented Mar 8, 2022

Hey, svg-pan-zoom is a customized version, that's why its embed.
I can't remember the changes but includes some global variables exposure and event changes so they can be intercepted/cancelled, possibly others, svg-pan-zoom is not ideal and the code its old but its quick to setup and use.

@emeric254
Copy link
Contributor Author

Ok no problem good to know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants