Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate conditional type depending on beautifier enabled setting #125

Open
tiagosiebler opened this issue Aug 11, 2021 · 1 comment
Open

Comments

@tiagosiebler
Copy link
Owner

Depending on whether the beautifier is enabled, some numbers may be strings:
https://github.com/tiagosiebler/binance/blob/v2.0.0/beta/src/types/shared.ts#L1-L3

beautifyResponses?: boolean;

Would love to conditionally set the type to number or string, depending on the state of that setting. There must be a way...

@tiagosiebler
Copy link
Owner Author

See #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant