-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate values for parameter 'symbols[]' https://api.binance.com/api/v3/ticker #507
Comments
That's a bug! Binance has a peculiar way of handling arrays in requests - I'll push a fix shortly. Thanks for reporting it! |
fix(v2.15.6, #507): correct handling for symbols array in rolling window tickers endpoint
Hi @jamesbayly - merged via #508 Should be on npm shortly, as of version v2.15.6. Thanks again for reporting it - let me know if you notice any other issues. |
Thanks for the quick fix, tested and confirmed! |
Hi @tiagosiebler I believe you've created another bug during this fix: getRollingWindowTicker(params) {
if (params && params['symbols'] && Array.isArray(params['symbols'])) {
const symbolsQueryParam = JSON.stringify(params.symbols);
return this.get('api/v3/ticker?symbols=' + symbolsQueryParam);
}
return this.get('api/v3/ticker', params);
} if I include |
That was a silly mistake, and a reminder for me to be more careful when multitasking. Apologies, fix incoming via #511 - should be on npm shortly as of v2.15.7. Thank you for pointing it out. |
fix(v2.5.7, #507): fix missing parameters when passing symbols in rolling tickers
results in
The text was updated successfully, but these errors were encountered: