Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missmatch in type for NewFuturesOrderParams #521

Closed
rokamon1997 opened this issue Feb 23, 2025 · 2 comments · Fixed by #522
Closed

Missmatch in type for NewFuturesOrderParams #521

rokamon1997 opened this issue Feb 23, 2025 · 2 comments · Fixed by #522

Comments

@rokamon1997
Copy link

rokamon1997 commented Feb 23, 2025 •
edited
Loading

Hello,

the method with params of type NewFuturesOrderParams has property newOrderRespType which is of type OrderResponseType. Which isn't completely correct since "ACK" and "RESULT" are the only valid values per API specifications (https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api). The value "FULL" acts as if default ("ACK") was sent.

There should probably also be a FuturesOrderResponseType type, which would only allow the mentioned values.
@JJ-Cro
Copy link
Contributor

JJ-Cro commented Feb 23, 2025

Ill look into it and edit, thanks!

@JJ-Cro
Copy link
Contributor

JJ-Cro commented Feb 23, 2025

If you need it fast, you can do a PR yourself!

@JJ-Cro JJ-Cro mentioned this issue Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v2.15.12): updated newOrderRespType for futures client JJ-Cro/binance
2 participants
@rokamon1997 @JJ-Cro