fix(web): add missing i18n keys for session.inactive banner#851
Open
swear01 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: initial
No issues found in the locale-only diff. Residual risk: no automated check currently guarantees every t(...) key exists in each locale dictionary, so similar missing-key regressions can still slip through elsewhere.
Testing
Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inactive-session banner rendered by
SessionChat.tsxreferenced two translation keys —session.inactive.autoResumeandsession.inactive.cannotResume— that were never added to the locale dictionaries, so the UI showed the raw key string.Added both keys to
en.tsandzh-CN.ts.Verified with
bun typecheckandbun run test(all packages green).