appcd-default-plugins v4

packages/appcd-core/CHANGELOG.md

@@ -1,5 +1,6 @@
-# v2.8.1
+# v2.9.0
 
+ * chore: Updated to `[email protected]`,
  * chore: Updated dependencies
 
 # v2.8.0 (Jun 25, 2019)

packages/appcd-core/package.json

@@ -20,7 +20,7 @@
     "appcd-agent": "^1.1.6",
     "appcd-config": "^1.3.0",
     "appcd-config-service": "^2.0.0",
-    "appcd-default-plugins": "^3.0.0",
+    "appcd-default-plugins": "^4.0.0",
     "appcd-dispatcher": "^2.0.0",
     "appcd-fs": "^1.1.7",
     "appcd-fswatch-manager": "^2.0.0",

packages/appcd-core/src/server.js

@@ -5,6 +5,7 @@ import fs from 'fs-extra';
 import FSWatcher from 'appcd-fswatcher';
 import FSWatchManager from 'appcd-fswatch-manager';
 import globalModules from 'global-modules';
+import installDefaultPlugins from 'appcd-default-plugins';
 import os from 'os';
 import path from 'path';
 import PluginManager from 'appcd-plugin';
@@ -188,6 +189,9 @@ export default class Server {
 		this.systems.subprocessManager = new SubprocessManager();
 		Dispatcher.register('/appcd/subprocess', this.systems.subprocessManager);
 
+		// install default plugins
+		await installDefaultPlugins(path.join(homeDir, 'plugins'));
+
 		// init the plugin manager
 		this.systems.pluginManager = new PluginManager({
 			paths: [

packages/appcd-default-plugins/.npmignore

@@ -11,7 +11,6 @@ gulpfile.js
 junit.xml
 node_modules
 npm-debug.log
-/plugins
 retire_output.json
 yarn-error.log
 /src

packages/appcd-default-plugins/CHANGELOG.md

@@ -1,5 +1,6 @@
-# v3.0.1
+# v4.0.0
 
+ * BREAKING CHANGE: Default plugins are now installed at runtime instead of postinstall.
  * chore: Updated dependencies
 
 # v3.0.0 (Jun 25, 2019)
@@ -9,6 +10,9 @@
  * BREAKING CHANGE: Plugins are installed into `"~/.appcelerator/appcd/plugins"` instead of the
    `"appcd-default-plugins/plugins"` directory to avoid permission issues when npm installing
    `appcd` globally using `sudo` due to npm dropping root before running the post install script.
+   UPDATE: Turns out that this won't work because unless there's an explicit `user` set in the
+   npm config, it defaults to the user `nobody` which does not have write permissions to the
+   user's home directory.
 
 # v2.0.0 (Jun 6, 2019)
 

packages/appcd-default-plugins/README.md

@@ -5,22 +5,21 @@ user's appcd home directrory (e.g. `"~/.appcelerator/appcd/plugins"`).
 
 Visit https://github.com/appcelerator/appc-daemon for more information.
 
-## Overview
+## Usage
 
-After installing `appcd-default-plugins`, a post-install script will run and download every major
-plugin release and puts it in the `"~/.appcelerator/appcd/plugins"` directory.
+```js
+import installDefaultPlugins from 'appcd-default-plugins';
 
-If any of the plugins match locally linked packages using _yarn_, then it will use those instead of
-installing from _npm_.
+await installDefaultPlugins('/path/to/plugins/dir');
+```
 
-A list of packages to be installed is used to create a monorepo in the `plugins` directory, then
-it runs `lerna` to initialize it.
+`installDefaultPlugins()` will download all default plugins if not already installed. If any of the
+plugins match locally linked packages using _yarn_, then it will use those instead of installing
+from _npm_.
 
-The post-install script will detect if _yarn_ is installed. If found, it will initialize the
-monorepo using _yarn_'s workspaces, otherwise it fallsback to _npm_ with hoisting.
-
-If at all possible, you should install _yarn_ before installing `appcd-default-plugins`. yarn is
-about 3 times faster and uses about 75% less disk space.
+The default plugins are installed into a `packages` directory inside the specified plugins
+directory, then it initializes the plugins directory as a monorepo and runs `lerna bootstrap` using
+`yarn`.
 
 ## Legal
 

packages/appcd-default-plugins/gulpfile.js

@@ -0,0 +1,8 @@
+'use strict';
+
+require('appcd-gulp')({
+	exports,
+	pkgJson:  require('./package.json'),
+	template: 'standard',
+	babel:    'node8'
+});

packages/appcd-default-plugins/package.json

@@ -1,18 +1,32 @@
 {
   "name": "appcd-default-plugins",
-  "version": "3.0.0",
+  "version": "4.0.0",
   "description": "A psuedo package that bundles all default appcd plugins.",
+  "main": "./dist/index",
   "author": "Axway, Inc. <[email protected]>",
   "maintainers": [
     "Chris Barber <[email protected]>"
   ],
   "license": "Apache-2.0",
+  "scripts": {
+    "build": "gulp build",
+    "coverage": "gulp coverage",
+    "docs": "gulp docs",
+    "prepare": "gulp build",
+    "test": "gulp test"
+  },
   "dependencies": {
+    "appcd-logger": "^2.0.2",
     "fs-extra": "^8.0.1",
+    "globule": "^1.2.1",
     "lerna": "^3.15.0",
     "pacote": "^9.5.1",
     "semver": "^6.1.2",
-    "which": "^1.3.1"
+    "yarn": "^1.16.0"
+  },
+  "devDependencies": {
+    "appcd-gulp": "^2.1.1",
+    "tmp": "^0.1.0"
   },
   "plugins": {
     "@appcd/plugin-android": [
@@ -37,9 +51,6 @@
       "^1.4.0"
     ]
   },
-  "scripts": {
-    "postinstall": "node postinstall.js"
-  },
   "homepage": "https://github.com/appcelerator/appc-daemon/tree/master/packages/appcd-default-plugins",
   "bugs": "https://github.com/appcelerator/appc-daemon/issues",
   "repository": "https://github.com/appcelerator/appc-daemon"