update bit64::as.integer64 use in test (#1567)

And update snapshots

Author: edward-burn

.github/workflows/test-coverage.yaml

@@ -6,7 +6,9 @@ on:
   pull_request:
     branches: [main, master]
 
-name: test-coverage
+name: test-coverage.yaml
+
+permissions: read-all
 
 jobs:
   test-coverage:
@@ -15,36 +17,47 @@ jobs:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: r-lib/actions/setup-r@v2
         with:
           use-public-rspm: true
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
-          extra-packages: any::covr
+          extra-packages: any::covr, any::xml2
           needs: coverage
 
       - name: Test coverage
         run: |
-          covr::codecov(
+          cov <- covr::package_coverage(
             quiet = FALSE,
             clean = FALSE,
             install_path = file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package")
           )
+          print(cov)
+          covr::to_cobertura(cov)
         shell: Rscript {0}
 
+      - uses: codecov/codecov-action@v5
+        with:
+          # Fail if error if not on PR, or if on PR and token is given
+          fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }}
+          files: ./cobertura.xml
+          plugins: noop
+          disable_search: true
+          token: ${{ secrets.CODECOV_TOKEN }}
+
       - name: Show testthat output
         if: always()
         run: |
           ## --------------------------------------------------------------------
-          find ${{ runner.temp }}/package -name 'testthat.Rout*' -exec cat '{}' \; || true
+          find '${{ runner.temp }}/package' -name 'testthat.Rout*' -exec cat '{}' \; || true
         shell: bash
 
       - name: Upload test results
         if: failure()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: coverage-test-failures
           path: ${{ runner.temp }}/package

NEWS.md

@@ -1,5 +1,7 @@
 # dbplyr (development version)
 
+* Fix for failing snapshot tests (@edward-burn, #1567). 
+
 * Tightened argument checks for SQL translations. These changes should 
   result in more informative errors in cases where code already failed, possibly
   silently; if you see errors with code that used to run correctly, please report 

tests/testthat/_snaps/pillar.md

@@ -8,8 +8,8 @@
     Output
       [1] "# Source:   SQL [3 x 1]"
     Code
-      # Number of rows still can't be shown
-      x <- memdb_frame(a = 1:11) %>% filter(a > 0)
+      # Number of rows still can't be shown if above 20
+      x <- memdb_frame(a = 1:21) %>% filter(a > 0)
       setup <- pillar::tbl_format_setup(x)
       tbl_format_header(x, setup)[[1]]
     Output

tests/testthat/_snaps/tbl-sql.md

@@ -3,7 +3,7 @@
     Code
       mf2
     Output
-      # Source:   SQL [3 x 2]
+      # Source:   SQL [?? x 2]
       # Database: sqlite ?.?.? [:memory:]
             x     y
         <int> <int>

tests/testthat/test-backend-postgres.R

@@ -335,7 +335,7 @@ test_that("casts `y` column for local df", {
 
   out <- tibble(
     id = bit64::as.integer64(1:2),
-    val = bit64::as.integer64(10L, 20L),
+    val = bit64::as.integer64(c(10L, 20L)),
     arr = structure(c("{1,2}", "{1,2,3}"), class = "pq__int4")
   )
   expect_equal(

tests/testthat/test-pillar.R

@@ -5,8 +5,8 @@ test_that("custom header", {
     setup <- pillar::tbl_format_setup(x)
     tbl_format_header(x, setup)[[1]]
 
-    "Number of rows still can't be shown"
-    x <- memdb_frame(a = 1:11) %>% filter(a > 0)
+    "Number of rows still can't be shown if above 20"
+    x <- memdb_frame(a = 1:21) %>% filter(a > 0)
     setup <- pillar::tbl_format_setup(x)
     tbl_format_header(x, setup)[[1]]
   })